linux-kernel - Re: [PATCH 22/27] score: create kernel files signal.c sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF3AABEDAD.28BB4A96-ON482575D4.0024BA2D-482575D4.002550FA@sunplusct.com>
Date:	Sat, 13 Jun 2009 14:43:08 +0800
From:	liqin.chen@...plusct.com
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-arch@...r.kernel.org, linux-arch-owner@...r.kernel.org,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH 22/27] score: create kernel files signal.c sys_score.c time.c

linux-arch-owner@...r.kernel.org 写于 2009-06-10 01:52:47:

> On Tuesday 09 June 2009, liqin.chen@...plusct.com wrote:
> > +asmlinkage long sys_mmap(unsigned long addr, size_t len,
> > +                       unsigned long prot, unsigned long flags,
> > +                       unsigned long fd, off_t offset)
> > +{
> > +       int err = -EINVAL;
> > +
> > +       if (offset & ~PAGE_MASK) {
> > +               printk(KERN_INFO "no pagemask in mmap\r\n");
> > +               goto out;
> > +       }
> > +
> > +       err = sys_mmap2(addr, len, prot, flags, fd, offset >> 
PAGE_SHIFT);
> > +out:
> > +       return err;
> > +}
> 
> A 32 bit kernel should only need sys_mmap2, not sys_mmap, because it is
> trivial to convert in user space.
> 
> > +
> > +asmlinkage long score_vfork(struct pt_regs *regs)
> > +{
> > +       return do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, 
regs->regs[0],
> > +                                               regs, 0, NULL, NULL);
> > +}
> > +
> > +/*
> > + * Fork a new task - this creates a new program thread.
> > + * This is called indirectly via a small wrapper
> > + */
> > +asmlinkage int
> > +score_fork(struct pt_regs *regs)
> > +{
> > +       return do_fork(SIGCHLD, regs->regs[0], regs, 0, NULL, NULL);
> > +}
> 
> Similarly, you should not need vfork and fork any more, because they can
> be handled in user space through clone().
> 

OK, I remove these from my code.

Best Regards
liqin
--