linux-kernel - Re: 2.6.30 enabling cpu1 on resume fails after suspend to memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906141400.27331.rjw@sisk.pl>
Date:	Sun, 14 Jun 2009 14:00:25 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Benjamin S." <sbenni@....de>, Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, js@...21.net,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Matthew Wilcox <matthew@....cx>
Subject: Re: 2.6.30 enabling cpu1 on resume fails after suspend to memory

On Sunday 14 June 2009, Benjamin S. wrote:
> On Sun, 14 Jun 2009 13:19:40 +0200
> "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> 
> > On Sunday 14 June 2009, Benjamin S. wrote:
> > > 
> > > On Sun, 14 Jun 2009 12:35:24 +0200
> > > "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> > > 
> > > > Thanks for the report, the problem seems to be related to the chipset, because
> > > > I'm unable to reproduce it with SB600 and a fairly new AMD CPU.
> > > > 
> > > > Does the resume work if you comment out suspend_device_irqs() and
> > > > resume_device_irqs() in drivers/base/power/main.c ?
> > > 
> > > Yes, 2.6.30 without the two lines resumes without problems.\
> > 
> > Does it help (with the two lines present again) if the kernel is compiled with
> > CONFIG_PCI_MSI unset?
> 
> Yes, it works.

OK, we need some help.

Ingo,

Evidently, the change of the interrupt handling during suspend-resume,
commit 2ed8d2b3a81bdbb0418301628ccdb008ac9f40b7 (PM: Rework handling of
interrupts during suspend-resume) broke resume (specifically, the enabling of
nonboot CPUs) on the Benjamin's machine, but only if MSI support is enabled.
Also, resume works if suspend_device_irqs() and resume_device_irqs() in
drivers/base/power/main.c are commented out.

Is there anything the MSI code does in __enable_irq() and/or __disable_irq()
that might cause this problem to appear?

Best,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/