linux-kernel - Re: [PATCH 0/3] kbuild: some scripts/config improvements (try 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090614204849.GD3187@uranus.ravnborg.org>
Date:	Sun, 14 Jun 2009 22:48:49 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] kbuild: some scripts/config improvements (try 2)

On Thu, Jun 04, 2009 at 07:47:08AM +0200, Michal Marek wrote:
> On Wed, Jun 03, 2009 at 10:16:46PM +0200, Andi Kleen wrote:
> > On Wed, Jun 03, 2009 at 09:25:20PM +0200, Sam Ravnborg wrote:
> > > On Mon, May 25, 2009 at 04:43:20PM +0200, Michal Marek wrote:
> > > > Hi,
> > > > 
> > > > I simplified the awk script a bit, made it awk ... && mv and removed the
> > > > --set option.
> > > > 
> > > > Michal Marek (3):
> > > >   kbuild: handle non-existing options in scripts/config
> > > >   kbuild: simplify argument loop in scripts/config
> > > >   kbuild: add generic --set-str option to scripts/config
> > > 
> > > Andi - do I have your ack on this serie?
> > 
> > Reluctantly -- most bits are ok, but the awk change seems quite overcomplicated
> > and I don't like it particularly.
> 
> What about this one? The other two patches apply apply at slightly
> different offsets.
> 
> Subject: [PATCH 1/3] kbuild: handle non-existing options in scripts/config
> 
> If an option does not exist in .config, set it at the end of the file.
> 
> Signed-off-by: Michal Marek <mmarek@...e.cz>

Looked readable - compared to the awk stuff.
I have applied all three patches.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/