linux-kernel - Re: [PATCH] scripts/setlocalversion on readonly source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.01.0906141336150.6439@bogon>
Date:	Sun, 14 Jun 2009 13:46:48 -0700 (PDT)
From:	Christian Kujau <lists@...dbynature.de>
To:	Sam Ravnborg <sam@...nborg.org>
cc:	Nico Schottelius <nico-linuxsetlocalversion@...ottelius.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] scripts/setlocalversion on readonly source

On Sun, 14 Jun 2009, Sam Ravnborg wrote:
> > Do not update index on read only media.
> > Idea published by Christian Kujau <lists@...dbynature.de>.
> > 
> > diff --git a/scripts/setlocalversion b/scripts/setlocalversion
> > index 0079047..46989b8 100755
> > --- a/scripts/setlocalversion
> > +++ b/scripts/setlocalversion
> > @@ -39,8 +39,10 @@ if head=`git rev-parse --verify --short HEAD 2>/dev/null`; then
> >  	        printf -- '-svn%s' "`git svn find-rev $head`"
> >  	fi
> >  
> > -	# Are there uncommitted changes?
> > -	git update-index --refresh --unmerged > /dev/null
> > +	# Update index only on r/w media
> > +	[ -w . ] && git update-index --refresh --unmerged > /dev/null
> > +
> > +	# Check for uncommitted changes
> >  	if git diff-index --name-only HEAD | grep -v "^scripts/package" \
> >  	    | read dummy; then
> >  		printf '%s' -dirty
> 
> Please sign-off future patches.
> I applied this with no signoff - but this is an exception.

I'm not sure if we want to have patches w/o a signoff in the tree; but I 
could only add a

   Tested-by: Christian Kujau <lists@...dbynature.de>

since it's Nico's patch now.

Thanks,
Christian.
-- 
BOFH excuse #446:

Mailer-daemon is busy burning your message in hell.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/