linux-kernel - Re: [PATCH] ftrace,arm: add notrace to ARM sched_clock routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090614213049.GA15366@linux-sh.org>
Date:	Mon, 15 Jun 2009 06:30:49 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Linus Walleij <linus.ml.walleij@...il.com>
Cc:	Tim Bird <tim.bird@...sony.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.arm.linux.org.uk>,
	linux kernel <linux-kernel@...r.kernel.org>,
	Russell King <rmk@....linux.org.uk>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...e.hu>, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] ftrace,arm: add notrace to ARM sched_clock routines - resend

On Sun, Jun 14, 2009 at 07:51:04PM +0200, Linus Walleij wrote:
> 2009/6/13 Tim Bird <tim.bird@...sony.com>:
> 
> > Add notrace attribute to sched_clock, to avoid
> > recursion with ftrace function tracing.
> >
> > Signed-off-by: Tim Bird <tim.bird@...sony.com>
> > ---
> >  arch/arm/mach-mmp/time.c       |    2 +-
> >  arch/arm/mach-pxa/time.c       |    2 +-
> >  arch/arm/mach-realview/core.c  |    2 +-
> >  arch/arm/mach-sa1100/generic.c |    2 +-
> >  arch/arm/mach-versatile/core.c |    2 +-
> >  arch/arm/plat-omap/common.c    |    4 ++--
> >  6 files changed, 7 insertions(+), 7 deletions(-)
> 
> And now that Paul Mundt is making it possible to use the default
> sched_clock() with the generic clocksource and the OMAP hack
> will likely go away, should the default implementation in
> kernel/sched_clock.c also be tagged as
> unsigned long long notrace __attribute__((weak)) sched_clock(void)
> or something?
> 
> Should it be tagged notrace even if it's the old jiffybased one even?
> 
Thanks for pointing that out. Yes, the new generic version will need the
notrace attribute as well, I will include this in the next iteration.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/