linux-kernel - Re: [PATCH -rt] disable building all staging drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Jun 2009 01:00:44 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org, linux-rt@...gutronix.de,
	Thomas Gleixner <tglx@...utronix.de>,
	Ian Abbott <abbotti@....co.uk>,
	Frank Mori Hess <fmhess@...rs.sourceforge.net>
Subject: Re: [PATCH -rt] disable building all staging drivers

Hi Greg,

On Sun, Jun 14, 2009 at 04:28:02AM -0700, Greg KH wrote:
> On Sat, Jun 13, 2009 at 11:38:38PM +0200, Uwe Kleine-König wrote:
> > I know that at least COMEDI and RT2870 are broken with -rt,
> 
> I didn't know this, has anyone sent me a bug report?  What in -rt causes
> these drivers to break?
> 
> > but Thomas requested disabling all of staging.  He's the maintainer.
> 
> This seems like a patch to ensure that the staging drivers never get a
> chance to be fixed for any potential -rt issues.  How about just sending
> me bug reports instead?
COMEDI has:

  CC [M]  drivers/staging/comedi/comedi_fops.o
In file included from drivers/staging/comedi/comedidev.h:40,
                 from drivers/staging/comedi/comedi_fops.c:45:
drivers/staging/comedi/interrupt.h:27: error: conflicting types for ‘irqreturn_t’
include/linux/irqreturn.h:14: error: previous declaration of ‘irqreturn_t’ was here
In file included from drivers/staging/comedi/comedidev.h:40,
                 from drivers/staging/comedi/comedi_fops.c:45:
drivers/staging/comedi/interrupt.h:30:1: warning: "IRQ_RETVAL" redefined
In file included from include/linux/interrupt.h:10,
                 from drivers/staging/comedi/interrupt.h:22,
                 from drivers/staging/comedi/comedidev.h:40,
                 from drivers/staging/comedi/comedi_fops.c:45:
include/linux/irqreturn.h:15:1: warning: this is the location of the previous definition
make[3]: *** [drivers/staging/comedi/comedi_fops.o] Error 1
make[2]: *** [drivers/staging/comedi] Error 2
make[1]: *** [drivers/staging] Error 2
make: *** [drivers] Error 2

commit

	http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commitdiff;h=bedd30d986a05e32dc3eab874e4b9ed8a38058bb
	
removes the #define IRQ_NONE and drivers/staging/comedi/interrupt.h has

	#ifndef IRQ_NONE
	typedef void irqreturn_t;
	#define IRQ_NONE
	#define IRQ_HANDLED
	#define IRQ_RETVAL(x) (void)(x)
	...

Note that Linus merged bedd30d986a05e32dc3eab874e4b9ed8a38058bb already
so that problem should exist on mainline now, too.  (I havn't tried
though.)

I cannot reproduce the failure I saw for RT2870 at the moment.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/