linux-kernel - Re: [PATCH] kmemtrace:fix undeclared 'PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1244960266.4968.162.camel@falcon>
Date:	Sun, 14 Jun 2009 14:17:46 +0800
From:	Wu Zhangjin <wuzhangjin@...il.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h

On Sun, 2009-06-14 at 08:59 +0300, Pekka Enberg wrote:
> On Sun, Jun 14, 2009 at 8:54 AM, Wu Zhangjin<wuzhangjin@...il.com> wrote:
> > From: Wu Zhangjin <wuzj@...ote.com>
> >
> > when compiling linux-mips with kmemtrace enabled, this error will be
> > there:
> >
> > include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
> >                                a function)
> >
> > I checked the source code and found trace_seq.h used PAGE_SIZE but not
> > include the relative header file, so, fix it via adding the header file
> > <asm/page.h>
> >
> > this error will not be triggered in linux-x86 for there is a
> > <asm/page.h> header file included in a certain header file. but which
> > not means <asm/page.h> is not needed in trace_seq.h
> >
> > Signed-off-by: Wu Zhangjin <wuzj@...ote.com>
> 
> This looks like a generic tracing issue, not a kmemtrace problem so
> the subject line needs fixing. But the change looks good to me:
> 
so, what about this subject?
	
  ftrace: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h 

> Acked-by: Pekka Enberg <penberg@...helsinki.fi>

will add it later.

thanks!
Wu Zhangjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/