linux-kernel - Re: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245048698.5239.9.camel@subratamodak.linux.ibm.com>
Date:	Mon, 15 Jun 2009 12:21:38 +0530
From:	Subrata Modak <subrata@...ux.vnet.ibm.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	netdev@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	Linuxppc-dev <Linuxppc-dev@...abs.org>,
	Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Linux-Next <linux-next@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>
Subject: Re: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig
	[drivers/net/lance.o]


On Thu, 2009-06-11 at 09:20 +0530, Subrata Modak wrote: 
> Hi Benjamin/Paul,
> 
> >On Thu, 2009-06-04 at 19:02 +0530, Subrata Modak wrote:
> >CC      drivers/net/lance.o
> > drivers/net/lance.c: In function 'lance_probe1':
> > drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
> > drivers/net/lance.c: In function 'lance_rx':
> > drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
> > make[2]: *** [drivers/net/lance.o] Error 1
> > make[1]: *** [drivers/net] Error 2
> > make: *** [drivers] Error 2
> 
> Reference: http://lkml.org/lkml/2009/6/4/240,
> To fix the following build error:
> 
> drivers/net/lance.c: In function 'lance_probe1':
> drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
> drivers/net/lance.c: In function 'lance_rx':
> drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
> make[2]: *** [drivers/net/lance.o] Error 1
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
> 
> I would like to propose the following patch. The prototypes for the functions:
> 'isa_virt_to_bus' & 'isa_virt_to_bus' are existing for some archs like the
> mips, x86, parisc, arm & alpha, but, is missing for powerpc. Is it safe to
> introduce the following soultion for powerpc ? It fixes the build problem
> i reported earlier.
> 
> Signed-off-by: Subrata Modak <subrata@...ux.vnet.ibm.com>
> ---

Benjamin,

I am not sure whether you liked the following patch to solve the above
problem. Do, you want me address some other issue(s)/fixes for this ?

Regards--
Subrata

> 
> --- linux-2.6.30-rc8/arch/powerpc/include/asm/io.h.orig	2009-06-10 21:56:49.000000000 -0500
> +++ linux-2.6.30-rc8/arch/powerpc/include/asm/io.h	2009-06-10 22:21:35.000000000 -0500
> @@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig
>  #define mmio_outsw(addr, src, count)	writesw(addr, src, count)
>  #define mmio_outsl(addr, src, count)	writesl(addr, src, count)
> 
> +#define isa_virt_to_bus		virt_to_phys
> +#define isa_bus_to_virt		phys_to_virt
> +
>  /**
>   *	virt_to_phys	-	map virtual addresses to physical
>   *	@address: address to remap
> 
> ---
> Regards--
> Subrata
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/