linux-kernel - Re: [PATCH 21/22] HWPOISON: send uevent to report memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Jun 2009 17:56:39 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Mel Gorman <mel@....ul.ie>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Nick Piggin <npiggin@...e.de>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	"riel@...hat.com" <riel@...hat.com>,
	"chris.mason@...cle.com" <chris.mason@...cle.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH 21/22] HWPOISON: send uevent to report memory corruption

On Mon, Jun 15, 2009 at 02:29:34PM +0800, Andi Kleen wrote:
> On Mon, Jun 15, 2009 at 10:45:41AM +0800, Wu Fengguang wrote:
> > This allows the user space to do some flexible policies.
> > For example, it may either do emergency sync/shutdown
> > or to schedule reboot at some convenient time, depending
> > on the severeness of the corruption.
> > 
> 
> I don't think it's a good idea to export that much detailed information.
> That would become a stable ABI, but might not be possible to keep
> all these details stable. e.g. map count or reference count are
> internal implementation details that shouldn't be exposed.
> And what is an user space application to do with the inode? Run
> find -inum? 

I had plan to export file path too, if available. But you are right,
we should really think twice before exporting them.

> Also we already report the event using low level logging mechanism.
> in a relatively stable form.
> 
> It's also unclear to me what an application would do with that much
> detail.
> 
> I would suggest to drop this part and the earlier flags move.
> 
> Please only bug fixes are this stage.

OK, I'll get rid of the uevent patches numbered 16-21 in the next release.

Thanks,
Fengguang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/