linux-kernel - Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090615192919.2cc506a0@dxy.sh.intel.com>
Date:	Mon, 15 Jun 2009 19:29:19 +0800
From:	Alek Du <alek.du@...el.com>
To:	Ben Dooks <ben-linux@...ff.org>
CC:	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and
 gpio_alt_func features to GPIOLIB

On Mon, 15 Jun 2009 17:50:23 +0800
Ben Dooks <ben-linux@...ff.org> wrote:

> > +enum gpio_trigger_t {
> > +	DETECT_LEVEL_LOW = -2,
> > +	DETECT_EDGE_FALLING = -1,
> > +	DETECT_DISABLE = 0,
> > +	DETECT_EDGE_RISING = 1,
> > +	DETECT_LEVEL_HIGH = 2,
> > +	DETECT_EDGE_BOTH = 3,
> > +};
> 
> wny not reuse the IRQ trigger types?
> 

Don't know it this is a good reason: the IRQ trigger name IRQ_TYPE_*
seems not good as DETECT_*. Since not all GPIO device would have IRQ line
connected to interrupt controller -- some of them just set a trigger bit
when detection happens.

Thanks,
Alek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/