linux-kernel - Re: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090615132248.GB14555@elf.ucw.cz>
Date:	Mon, 15 Jun 2009 15:22:48 +0200
From:	Pavel Machek <pavel@....cz>
To:	Brian Swetland <swetland@...gle.com>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream
	device

Hi!

> Signed-off-by: Brian Swetland <swetland@...gle.com>
> ---
>  arch/arm/mach-msm/Kconfig       |    6 ++
>  arch/arm/mach-msm/Makefile      |    1 +
>  arch/arm/mach-msm/board-dream.c |  113 +++++++++++++++++++++++++++++++++++++++
>  arch/arm/mach-msm/board-dream.h |    5 ++
>  4 files changed, 125 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-msm/board-dream.c
>  create mode 100644 arch/arm/mach-msm/board-dream.h

Thanks for renaming the board-* files...

> diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig
> index 35f2a90..f780086 100644
> --- a/arch/arm/mach-msm/Kconfig
> +++ b/arch/arm/mach-msm/Kconfig
> @@ -34,4 +34,10 @@ config MACH_HALIBUT
>  	help
>  	  Support for the Qualcomm SURF7201A eval board.
>  
> +config MACH_TROUT
> +	default y
> +	bool "HTC Dream (aka trout)"
> +	help
> +	  Support for the HTC Dream, T-Mobile G1, Android ADP1 devices.
> +
>  endif

...but I guess renaming config option makes sense too..

> +static void __init trout_init_irq(void)
> +{
> +	msm_init_irq();
> +}

...and most occurences of trout, here, too... (I'm not sure if some
are required for compatibility with existing userland?)
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/