linux-kernel - RE: [PATCH] cpumask: avoid playing with cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6453C3CB8E2B3646B0D020C112613273036209AB@sausexmb4.amd.com>
Date:	Mon, 15 Jun 2009 10:40:09 -0500
From:	"Langsdorf, Mark" <mark.langsdorf@....com>
To:	"Rusty Russell" <rusty@...tcorp.com.au>,
	"Dave Jones" <davej@...hat.com>
CC:	<cpufreq@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	"Ingo Molnar" <mingo@...hat.com>
Subject: RE: [PATCH] cpumask: avoid playing with cpus_allowed in powernow-k8.c

> cpumask: avoid playing with cpus_allowed in powernow-k8.c
>     
> It's generally a very bad idea to mug some process's cpumask: it could
> legitimately and reasonably be changed by root, which could break us
> (if done before our code) or them (if we restore the wrong value).
>     
> I did not replace powernowk8_target; it needs fixing, but it grabs a
> mutex (so no smp_call_function_single here) but Mark points out it can
> be called multiple times per second, so work_on_cpu is too heavy.
>     
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> To: davej@...hat.com
> To: cpufreq@...r.kernel.org
> Cc: mark.langsdorf@....com

I ran this over the weekend on a 24 core box without
any issues.  Please commit.

Acked-by: Mark Langsdorf <mark.langsdorf@....com>
Tested-by: Mark Langsdorf <mark.langsdorf@....com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/