linux-kernel - Re: [PATCH] tty_ldisc: propagate errors from tty_ldisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090615165126.1ecdff09@lxorguk.ukuu.org.uk>
Date:	Mon, 15 Jun 2009 16:51:26 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Vegard Nossum <vegard.nossum@...il.com>
Cc:	Pekka Enberg <penberg@...helsinki.fi>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty_ldisc: propagate errors from tty_ldisc_release

> Subject: [PATCH] tty_ldisc: propagate errors from tty_ldisc_release
> 
> This is probably better than just ignoring the errors.

tty_ldisc_halt doesn't return an error as such - it just reports whether
the work could be cancelled. Nor can we exit on error paths in those
situations.

Basically one or two cases need to know if we cancelled the work queue or
not (so they can restart it).

So NAK the patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/