linux-kernel - Re: [GIT PULL] voltage regulator updates for 2.6.31-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0906151027210.3305@localhost.localdomain>
Date:	Mon, 15 Jun 2009 10:28:31 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
cc:	Liam Girdwood <lrg@...mlogic.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] voltage regulator updates for 2.6.31-rc1



On Mon, 15 Jun 2009, Mark Brown wrote:

> On Mon, Jun 15, 2009 at 09:29:54AM -0700, Linus Torvalds wrote:
> > On Mon, 15 Jun 2009, Liam Girdwood wrote:
> 
> > >  include/linux/regulator/lp3971.h             |   51 +++
> 
> > Why the heck would "lp3971.h" be under "include/linux"? That makes no 
> > sense what-so-ever. 
> 
> > Why isn't it just
> 
> > 	drivers/regulator/lp3971.c
> > 	drivers/regulator/lp3971.h
> 
> It defines a platform data structure for the architecture code which
> instantiates the driver to use to pass configuration to the driver.  If
> the header were in drivers/regulator then any system using one of these
> regulators would need to peer into drivers/regulator in order to set up
> the driver.

A quick grep shows:

	[torvalds@...alem linux]$ git grep lp3971.h
	drivers/regulator/lp3971.c:#include <linux/regulator/lp3971.h>

ie _nobody_ includes lp3971.h except for lp3971.c.

So tell me again, why is that lp3971.h file separate from the only driver 
that uses it?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/