linux-kernel - Re: [PATCH] setup_affinity return 1 with failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2375c9f90906142020j74dd3849mc53cc7399ae4243c@mail.gmail.com>
Date:	Mon, 15 Jun 2009 11:20:25 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] setup_affinity return 1 with failure

On Sun, Jun 14, 2009 at 11:33 PM, Yong Zhang<yong.zhang0@...il.com> wrote:
> setup_affinity should return 1 when failure, then make checking in
> irq_select_affinity_usr() reasonable.
>
> Signed-off-by: Yong Zhang <yong.zhang0@...il.com>

Looks good.

Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>

> ---
>  kernel/irq/manage.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index aaf5c9d..8d2a992 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -137,7 +137,7 @@ int irq_set_affinity(unsigned int irq, const
> struct cpumask *cpumask)
>  static int setup_affinity(unsigned int irq, struct irq_desc *desc)
>  {
>        if (!irq_can_set_affinity(irq))
> -               return 0;
> +               return 1;
>
>        /*
>         * Preserve an userspace affinity setup, but make sure that
> --
> 1.6.0.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/