linux-kernel - Re: [tip:perfcounters/core] perf_counter: x86: Fix call-chain support to use NMI-safe methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090615205911.GC24554@elte.hu>
Date:	Mon, 15 Jun 2009 22:59:11 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	mingo@...hat.com, paulus@...ba.org, acme@...hat.com,
	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	penberg@...helsinki.fi, vegard.nossum@...il.com, efault@....de,
	npiggin@...e.de, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perfcounters/core] perf_counter: x86: Fix call-chain
	support to use NMI-safe methods


* H. Peter Anvin <hpa@...or.com> wrote:

> Linus Torvalds wrote:
> > 
> > On Mon, 15 Jun 2009, Jeremy Fitzhardinge wrote:
> >> We have to restore the usermode %gs somewhere...
> > 
> > None of this is useful for user-mode return _anyway_, since you have to 
> > restore %cs/%ss too. At that point, you have to use iret.
> 
> cs/ss you could potentially restore with sysret/sysexit, at least 
> for the common case.  Of course, this means more cases...

hm, does this really work? Using sysret there would be quite 
tempting. Does anyone know the rough cycle count difference between 
IRET and SYSRET on contemporary hardware?

Also, is SYSRET NMI-invariant? If yes then this would be a quite 
clean all-around solution: on modern hw we'd standardize on doing 
SYSRET from pretty much all the contexts. We'd get a nice speedup 
and also the NMI nested pagefaults fix.

Oh, compat mode. Doesnt SYSRET on Intel CPUs have the problem of not 
being able to switch back to 32-bit user-space?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/