linux-kernel - Re: [PATCH block#for-2.6.31] block: add request clone interface (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A35C0A4.20707@ct.jp.nec.com>
Date:	Mon, 15 Jun 2009 12:31:48 +0900
From:	Kiyoshi Ueda <k-ueda@...jp.nec.com>
To:	Jeff Moyer <jmoyer@...hat.com>
CC:	Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org,
	device-mapper development <dm-devel@...hat.com>,
	Boaz Harrosh <bharrosh@...asas.com>,
	"Jun'ichi Nomura" <j-nomura@...jp.nec.com>, k-ueda@...jp.nec.com
Subject: Re: [PATCH block#for-2.6.31] block: add request clone interface (v2)

Hi Jeff,

On 06/12/2009 11:33 PM +0900, Jeff Moyer wrote:
> Jens Axboe <jens.axboe@...cle.com> writes:
>> On Thu, Jun 11 2009, Jeff Moyer wrote:
>>> Jens Axboe <jens.axboe@...cle.com> writes:
>>> Is blk_rq_unprep_clone really the best name?
>>>           ^^^^^^
>> Probably not, but I'm not very good at coming up with elegant names.
>> Your email should have included a new suggestion :-)
> 
> Fair enough.  ;)
> 
>>  - blk_rq_unprep_clone(struct request *clone)
>>      * Frees cloned bios from the clone request.
> 
> Why not blk_rq_free_clone?

Because the 'clone' is not freed in this interface.
This interface frees only bios in the 'clone'.
Allocating/freeing the 'clone' are the caller's work, since
only the caller knows how to allocate/free it.

'prep' after 'alloc' and 'unprep' before 'free' is symmetric
and I feel a good candidate for my request-stacking driver,
so I chose it. 

Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/