linux-kernel - Re: [PATCH 5/6] Unified AVR32/AT91 MCI Driver Support for a VCC Pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8284b5b0906151516x6774545u6308e45049bb094c@mail.gmail.com>
Date:	Mon, 15 Jun 2009 15:16:49 -0700
From:	Rob Emanuele <poorarm@...reis.com>
To:	Michael Roth <mroth@...sie.de>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk,
	Haavard Skinnemoen <haavard.skinnemoen@...el.com>,
	Andrew Victor <avictor.za@...il.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-kernel@...r.kernel.org, drzeus-mmc@...eus.cx
Subject: Re: [PATCH 5/6] Unified AVR32/AT91 MCI Driver Support for a VCC Pin

That would be fine with me.

On Mon, Jun 15, 2009 at 2:35 PM, Michael Roth<mroth@...sie.de> wrote:
>
>> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
>> index 1c1a4b3..a639b93 100644
>> --- a/drivers/mmc/host/atmel-mci.c
>> +++ b/drivers/mmc/host/atmel-mci.c
>> @@ -214,6 +214,8 @@ struct atmel_mci_slot {
>>
>>       int                     detect_pin;
>>       int                     wp_pin;
>> +     int                     vcc_pin;
>> +     bool                    vcc_pin_act_low;
>
> Maybe, just 'vcc_active_low' is more clear?
>
> Most other kernel code use 'active_low' or 'xyz_active_low' as far as I can
> see.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/