linux-kernel - Re: [PATCH] LIB: remove unmatched write_lock() in gen_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090615152959.7d4f4982.akpm@linux-foundation.org>
Date:	Mon, 15 Jun 2009 15:29:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steve Wise <swise@...ngridcomputing.com>
Cc:	trivial@...nel.org, zygo.blaxell@...dros.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LIB: remove unmatched write_lock() in gen_pool_destroy

On Mon, 15 Jun 2009 17:04:15 -0500
Steve Wise <swise@...ngridcomputing.com> wrote:

> > this doesn't really qualify for trivial tree, as it introduces a 
> > significant code change. Adding some CCs.
> >
> >   
> 
> Looks ok to me.  Its dumb to aquire the lock you're gonna free anyway.  
> Maybe some BUG_ON() that sez nobody better be holding this lock?

CONFIG_DEBUG_OBJECTS_FREE could detect the freeing of a held rwlock. 
But probably it hasn't been wired up to handle rwlocks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/