linux-kernel - Re: [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200906151638.05008.david-b@pacbell.net>
Date:	Mon, 15 Jun 2009 16:38:04 -0700
From:	David Brownell <david-b@...bell.net>
To:	"Russell King - ARM Linux" <linux@....linux.org.uk>
Cc:	Baruch Siach <baruch@...s.co.il>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller

On Thursday 04 June 2009, Russell King - ARM Linux wrote:
> > +static unsigned int pl061_irq_startup(unsigned irq)
> > +{
> > +     int ret;
> > +
> > +     ret = gpio_request(irq_to_gpio(irq), "IRQ");
> > +     if (ret < 0) {
> > +             pr_warning("%s: warning: gpio_request(%d) returned %d\n",
> > +                             __func__, irq_to_gpio(irq), ret);
> > +             return 0;
> > +     }
> > +
> > +     gpio_direction_input(irq_to_gpio(irq));
> 
> I thought that it was not expected that claiming an interrupt would claim
> a GPIO automatically - in other words, it's the responsibility of the
> driver or platform itself to claim GPIOs for interrupts and ensure that
> they're properly configured.

You're right about that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/