linux-kernel - Re: [GIT pull] ntp updates for 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f1b08da0906151641u4cd964e6vf1a61afe50cc1d90@mail.gmail.com>
Date:	Mon, 15 Jun 2009 16:41:43 -0700
From:	john stultz <johnstul@...ibm.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Miroslav Lichvar <mlichvar@...hat.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [GIT pull] ntp updates for 2.6.31

On Mon, Jun 15, 2009 at 1:16 PM, john stultz<johnstul@...ibm.com> wrote:
> On Mon, Jun 15, 2009 at 7:06 AM, Thomas Gleixner<tglx@...utronix.de> wrote:
>> Linus,
>>
>> Please pull the latest timers-for-linus-ntp git tree from:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-for-linus-ntp
>>
>> Thanks,
>>
>>        tglx
>>
>> ------------------>
>> John Stultz (2):
>>      ntp: adjust SHIFT_PLL to improve NTP convergence
>>      ntp: fix comment typos
>
> Thomas,
>   Could we hold off on pushing this? I'm still working with Miroslav
> to try to work out a solution here from ntpd user-side.

Linus,
    You probably didn't see this before merging.  Could you yank the
above two patches?  Miroslav (RH package maintainer for ntpd), has
voiced concerns that the SHIFT_PLL patch breaks the NTP design and is
worried it may negatively effect NTP networks of systems running with
different SHIFT_PLL values.

While the patch does greatly improve NTP convergence times, and so far
no negative results have been seen in tests, its out of an abundance
of caution and a desire to keep the adjtimex behavior stable that I
requested Thomas and Ingo to hold off on merging this patch, while I
work with Miroslav to see if we cannot get the same benefit by
adjusting the userspace NTPd.

So if you could revert the two patches until we either sort things out
in userspace or I resubmit, I'd appreciate it.

Sorry for the mixup here.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/