linux-kernel - Re: [PATCH] regulator: Report regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2009 10:15:55 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: Report regulator_get() failure in virtual
 consumer

On Mon, 2009-06-15 at 20:01 +0100, Mark Brown wrote:
> The core will no longer complain so we should log an error here.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/regulator/virtual.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
> index e7db566..e953c18 100644
> --- a/drivers/regulator/virtual.c
> +++ b/drivers/regulator/virtual.c
> @@ -285,6 +285,8 @@ static int regulator_virtual_consumer_probe(struct platform_device *pdev)
>  	drvdata->regulator = regulator_get(&pdev->dev, reg_id);
>  	if (IS_ERR(drvdata->regulator)) {
>  		ret = PTR_ERR(drvdata->regulator);
> +		dev_err(&pdev->dev, "Failed to obtain supply '%s': %d\n",
> +			reg_id, ret);
>  		goto err;
>  	}
>  

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/