linux-kernel - Re: Bug: fio traps into kernel without exiting because futex has a deadloop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1245122195.2560.369.camel@ymzhang>
Date:	Tue, 16 Jun 2009 11:16:35 +0800
From:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Darren Hart <dvhltc@...ibm.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Bug: fio traps into kernel without exiting because futex has a
	deadloop

On Mon, 2009-06-15 at 09:57 +0200, Thomas Gleixner wrote:
> On Mon, 15 Jun 2009, Zhang, Yanmin wrote:
> > > +	ret = get_user_pages_fast(addr, 1, 1, &page);
> >
> > I checked function get_user_pages_fast. It might return negative, 0, or
> > positive value. 0 means it doesn't pin any page. So why does below statement
> > use (!ret) to put_page?
> 
> Hmm, darn. You are right. It needs to be (ret > 0)
I tested (ret > 0). It does work and I didn't find memory leak.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/