linux-kernel - Re: [PATCH 1/6] staging: android: binder: Remove some funny && usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A380494.6030506@goop.org>
Date:	Tue, 16 Jun 2009 13:46:12 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Daniel Walker <dwalker@...o99.com>
CC:	Greg Kroah-Hartman <greg@...ah.com>,
	Brian Swetland <swetland@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: android: binder: Remove some funny && usage

On 06/12/09 11:51, Daniel Walker wrote:
> Signed-off-by: Daniel Walker<dwalker@...o99.com>
> ---
>   drivers/staging/android/binder.c |   14 ++++++++------
>   1 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index 17d89a8..c37336d 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -2146,7 +2146,7 @@ static int binder_thread_read(struct binder_proc *proc,
>   	void __user *end = buffer + size;
>
>   	int ret = 0;
> -	int wait_for_proc_work;
> +	int wait_for_proc_work = 0;
>
>   	if (*consumed == 0) {
>   		if (put_user(BR_NOOP, (uint32_t __user *)ptr))
> @@ -2155,8 +2155,8 @@ static int binder_thread_read(struct binder_proc *proc,
>   	}
>
>   retry:
> -	wait_for_proc_work = thread->transaction_stack == NULL&&
> -				list_empty(&thread->todo);
> +	if (list_empty(&thread->todo)&&  thread->transaction_stack == NULL)
> +		wait_for_proc_work = 1;
>    

I think the original looks cleaner (in both cases).  Assigning a 
variable with the result of a boolean expression is perfectly 
reasonable.  Perhaps change the type of the variable to "bool" to make 
it a bit clearer what's going on.

(It would be a different matter if any of the expression had side-effects.)

     J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/