[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090616205747.GA6356@rhlx01.hs-esslingen.de>
Date: Tue, 16 Jun 2009 22:57:47 +0200
From: Andreas Mohr <andi@...as.de>
To: Ed Tomlinson <edt@....ca>
Cc: Borislav Petkov <petkovbb@...glemail.com>,
Peter Feuerer <peter@...e.net>, akpm@...ux-foundation.org,
Andreas Mohr <andi@...as.de>, Len Brown <len.brown@...el.com>,
Matthew Garrett <mjg59@...f.ucam.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RFC] Acer Aspire One fan control resume fix,
improvements
Hi,
On Tue, Jun 16, 2009 at 07:47:02AM -0400, Ed Tomlinson wrote:
> Please add this to the kernel now. I have been using version of this on my wife's
> acer since I installed linux on it. Its been doing its job as adverstised. This is not
> a core feature - its a driver. It works. Why not add it?
Seconded. Better not wait 18 months this time.
This being said, I'm unfortunately _still_ experiencing the resume issue (unexpected fan
state) from time to time after resume. Really needs more investigation
to get that fixed somehow, eventually.
Also, the pre_suspend_kernelmode variable is superfluous indeed, as mentioned this
can be simplified.
Atom emergency shutdown works fine on my machine (blocked fan sometimes,
going tick-tick-tick on boot etc., nice way to test this BIOS feature ;),
thus given this extra protection I believe the driver can be committed as is
anyway, nevermind any remaining driver issues which _might_ perhaps
eventually still exist.
Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists