linux-kernel - Re: [tip:perfcounters/core] perf record/report: Add call graph / call chain profiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245224279.13761.21585.camel@twins>
Date:	Wed, 17 Jun 2009 09:37:59 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Frederic Weisbecker <fweisbec@...il.com>, mingo@...hat.com,
	hpa@...or.com, paulus@...ba.org, acme@...hat.com,
	linux-kernel@...r.kernel.org, penberg@...helsinki.fi,
	efault@....de, arjan@...radead.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>
Subject: Re: [tip:perfcounters/core] perf record/report: Add call graph /
 call chain profiling

On Tue, 2009-06-16 at 10:09 +0200, Ingo Molnar wrote:
> * Frederic Weisbecker <fweisbec@...il.com> wrote:
> 
> > > @@ -43,11 +44,19 @@ static int		full_paths;
> > >  static unsigned long	page_size;
> > >  static unsigned long	mmap_window = 32;
> > >  
> > > +struct ip_chain_event {
> > > +	__u16 nr;
> > 
> > Is it needed to have the nr encoded in the ip_chain? We can 
> > already find it by doing kernel + user.
> 
> That's a good observation. Since we havent exposed the call-chain 
> bits in upstream version of the tools, we could still improve on 
> this a little bit.
> 
> I think the best would be context separators which occupy a special 
> address in some quiet corner of the 64-bit address space.
> 
> That way we'd have streams of u64 entries:
> 
>    ip-1
>    ip-2
>    CONTEXT_IRQ
>    ip-3
>    ip-4
>    CONTEXT_SYSCALL
>    ip-5
>    ip-6
> 
> The following contexts IDs would be useful:
> 
>   CONTEXT_NMI
>   CONTEXT_HARDIRQ
>   CONTEXT_SOFTIRQ
>   CONTEXT_KERNEL
>   CONTEXT_USER
>   CONTEXT_GUEST_NMI
>   CONTEXT_GUEST_HARDIRQ
>   CONTEXT_GUEST_SOFTIRQ
>   CONTEXT_GUEST_KERNEL
>   CONTEXT_GUEST_USER
> 
> The context IDs would occupy some rare and 
> unlikely-to-be-allocated-soon corner of the address space - say 
> startig at 0x8765432112345000. (and real RIPs would be filtered and 
> nudged just outside that space of a handful IDs.)

Right, that works too, but should we use (u64)-1..-4095 for that? We
already use that range for things like ERR_PTR() so its very unlikely we
have something sensible mapped there.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/