[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1245243186.4870.5.camel@subratamodak.linux.ibm.com>
Date: Wed, 17 Jun 2009 18:23:06 +0530
From: Subrata Modak <subrata@...ux.vnet.ibm.com>
To: David Brownell <david-b@...bell.net>
Cc: Arnd Bergmann <arnd@...db.de>, linux-usb@...r.kernel.org,
Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
Kumar Gala <galak@...nel.crashing.org>,
Linux-Kernel <linux-kernel@...r.kernel.org>,
Randy Dunlap <randy.dunlap@...cle.com>,
Linux-Next <linux-next@...r.kernel.org>,
Jon Smirl <jonsmirl@...il.com>,
Linuxppc-dev <Linuxppc-dev@...abs.org>,
Stephen Rothwell <sfr@...b.auug.org.au>, kernel@...tstofly.org
Subject: [BUILD FAILURE 02/04] Next June 04:PPC64 randconfig
[drivers/usb/host/ohci-hcd.o]
On Mon, 2009-06-15 at 12:21 +0530, Subrata Modak wrote:
> On Fri, 2009-06-12 at 15:05 +0530, Subrata Modak wrote:
> > On Tue, 2009-06-09 at 17:38 -0700, David Brownell wrote:
> > > On Friday 05 June 2009, Subrata Modak wrote:
> > > > Correct, it fixes the issue. However, since few changes might have gone
> > > > to the Kconfig, the patch does not apply cleanly. Below is the patch, just
> > > > a retake of the earlier one, but on the latest code.
> > >
> > > And it got mangled a bit along the way. Plus, the original one
> > > goofed up Kconfig dependency displays ... both issues fixed in
> > > this version, against current mainline GIT.
> > >
> > > If someone can verify all four PPC/OF/OHCI configs build on
> > > on PPC64, I'm OK with it.
> > >
> > > - Dave
> >
> > Dave,
> >
> > Sorry for being late. The patch fixes the issue on the latest git for
> > PPC64. Infact, the whole drivers/usb/host/ builds just fine:
> >
> > linux-2.6 # make drivers/usb/host/
> > CHK include/linux/version.h
> > CHK include/linux/utsrelease.h
> > SYMLINK include/asm -> include/asm-powerpc
> > CALL scripts/checksyscalls.sh
> > CC drivers/usb/host/ohci-hcd.o
> > CC drivers/usb/host/pci-quirks.o
> > CC drivers/usb/host/uhci-hcd.o
> > LD drivers/usb/host/built-in.o
> > CC [M] drivers/usb/host/isp116x-hcd.o
> > CC [M] drivers/usb/host/u132-hcd.o
> >
> > You can check in the patch now.
>
> Dave,
>
> Have you checked in this patch ? Or, does it require some more
> modification/updates from somebody´s side ?
>
Dave,
Would you consider checking in this patch ?
Regards--
Subrata
> Regards--
> Subrata
>
> >
> > Regards--
> > Subrata
> >
> > >
> > >
> > > ========== CUT HERE
> > > From: Arnd Bergmann <arnd@...db.de>
> > > Subject: fix build failure for PPC64 randconfig [usb/ohci]
> > >
> > > We could just make the USB_OHCI_HCD_PPC_OF option implicit
> > > and selected only if at least one of USB_OHCI_HCD_PPC_OF_BE
> > > and USB_OHCI_HCD_PPC_OF_LE are set.
> > >
> > > [ dbrownell@...rs.sourceforge.net: fix patch manglation and dependencies ]
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > > Resent-by: Subrata Modak <subrata@...ux.vnet.ibm.com>
> > > Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
> > > ---
> > > drivers/usb/host/Kconfig | 29 +++++++++++++++--------------
> > > 1 file changed, 15 insertions(+), 14 deletions(-)
> > >
> > > --- a/drivers/usb/host/Kconfig
> > > +++ b/drivers/usb/host/Kconfig
> > > @@ -180,26 +180,27 @@ config USB_OHCI_HCD_PPC_SOC
> > > Enables support for the USB controller on the MPC52xx or
> > > STB03xxx processor chip. If unsure, say Y.
> > >
> > > -config USB_OHCI_HCD_PPC_OF
> > > - bool "OHCI support for PPC USB controller on OF platform bus"
> > > - depends on USB_OHCI_HCD && PPC_OF
> > > - default y
> > > - ---help---
> > > - Enables support for the USB controller PowerPC present on the
> > > - OpenFirmware platform bus.
> > > -
> > > config USB_OHCI_HCD_PPC_OF_BE
> > > - bool "Support big endian HC"
> > > - depends on USB_OHCI_HCD_PPC_OF
> > > - default y
> > > + bool "OHCI support for OF platform bus (big endian)"
> > > + depends on USB_OHCI_HCD && PPC_OF
> > > select USB_OHCI_BIG_ENDIAN_DESC
> > > select USB_OHCI_BIG_ENDIAN_MMIO
> > > + ---help---
> > > + Enables support for big-endian USB controllers present on the
> > > + OpenFirmware platform bus.
> > >
> > > config USB_OHCI_HCD_PPC_OF_LE
> > > - bool "Support little endian HC"
> > > - depends on USB_OHCI_HCD_PPC_OF
> > > - default n
> > > + bool "OHCI support for OF platform bus (little endian)"
> > > + depends on USB_OHCI_HCD && PPC_OF
> > > select USB_OHCI_LITTLE_ENDIAN
> > > + ---help---
> > > + Enables support for little-endian USB controllers present on the
> > > + OpenFirmware platform bus.
> > > +
> > > +config USB_OHCI_HCD_PPC_OF
> > > + bool
> > > + depends on USB_OHCI_HCD && PPC_OF
> > > + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE
> > >
> > > config USB_OHCI_HCD_PCI
> > > bool "OHCI support for PCI-bus USB controllers"
> > >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists