linux-kernel - Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7BC400B3-3BF5-464F-9E0F-6A1427E5742D@kernel.crashing.org>
Date:	Wed, 17 Jun 2009 08:49:01 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	subrata@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	Li Yang <leoli@...escale.com>, Nathan Lynch <ntl@...ox.com>,
	Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
	Linux-Next <linux-next@...r.kernel.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Linuxppc-dev <Linuxppc-dev@...abs.org>,
	Tony Breeds <tony@...eyournoodle.com>, michael@...erman.id.au,
	Haiying Wang <Haiying.Wang@...escale.com>,
	"David S. Miller" <davem@...emloft.net>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]


On Jun 17, 2009, at 8:34 AM, Stephen Rothwell wrote:

> On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell <sfr@...b.auug.org.au 
> > wrote:
>>
>> Hi Kumar,
>>
>> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@...nel.crashing.org 
>> > wrote:
>>>
>>>
>>> I'm confused by the proposed fix as we already have *mdio & *ph
>>> defined in this function:
>>
>> Which tree are you looking at?  Linus' tree, and linux-next, do not  
>> have
>> those local variables ...
>
> Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework
> ucc_geth driver to use of_mdio infrastructure") removed the locals  
> along
> with their usages, then commit  
> 047584ce94108012288554a5f84585d792cc7f8f
> ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more  
> uses
> without adding the variables back.
>
> Here is the patch again:
>
> From: Subrata Modak <subrata@...ux.vnet.ibm.com>
> Subject: [PATCH] Fix build error in ucc_geth.c
>
> Fix the following build error:
>
> drivers/net/ucc_geth.c: In function bucc_geth_probeb:
> drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in  
> this function)
> drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is  
> reported only once
> drivers/net/ucc_geth.c:3822: error: for each function it appears in.)
> drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in  
> this function)
> make[2]: *** [drivers/net/ucc_geth.o] Error 1
>
> Signed-off-by: Subrata Modak <subrata@...ux.vnet.ibm.com>
>
> --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig	2009-06-10  
> 11:58:39.000000000 -0500
> +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c	2009-06-10  
> 22:28:13.000000000 -0500
> @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g
>
> static int ucc_geth_probe(struct of_device* ofdev, const struct  
> of_device_id *match)
> {
> +	struct device_node *mdio;
> +	const phandle *ph;
> 	struct device *device = &ofdev->dev;
> 	struct device_node *np = ofdev->node;
> 	struct net_device *dev = NULL;

ah... was looking at powerpc next which hasn't pulled in linus's  
latest tree w/netdev updates.

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/