linux-kernel - Re: [PATCH]x86-tsc.c : fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245248241.4870.12.camel@subratamodak.linux.ibm.com>
Date:	Wed, 17 Jun 2009 19:47:21 +0530
From:	Subrata Modak <subrata@...ux.vnet.ibm.com>
To:	"Figo.zhang" <figo1802@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, lkml <linux-kernel@...r.kernel.org>,
	Sumit Panchasara <sumit.panchasara@...fochips.com>,
	"'Sachin P Sant'" <sachinp@...ux.vnet.ibm.com>,
	"'H. Peter Anvin'" <hpa@...or.com>,
	"'Frans Pop'" <elendil@...net.nl>,
	"'Andi Kleen'" <andi@...stfloor.org>,
	"'Thomas Gleixner'" <tglx@...utronix.de>,
	"'Balbir Singh'" <balbir@...ux.vnet.ibm.com>
Subject: Re: [PATCH]x86-tsc.c : fix compile warning

> fix compile warning:
> arch/x86/kernel/tsc.c: In function ‘time_cpufreq_notifier’:
> arch/x86/kernel/tsc.c:635: warning: ‘dummy’ may be used uninitialized in
> this function
> 
> Signed-off-by: Figo.zhang <figo1802@...il.com>

Hello Figo,

Please refer to the following links on discussion on this issue earlier:
http://lkml.org/lkml/2009/5/19/312
http://lkml.org/lkml/2009/5/19/301
http://lkml.org/lkml/2009/5/20/23

I tried to fix it in some other way.

Regards--
Subrata

> ---
> arch/x86/kernel/tsc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index ae3180c..e65492a 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -632,7 +632,7 @@ static int time_cpufreq_notifier(struct
> notifier_block *nb, unsigned long val,
>                                void *data)
>  {
>        struct cpufreq_freqs *freq = data;
> -       unsigned long *lpj, dummy;
> +       unsigned long *lpj, dummy = 0;
> 
>        if (cpu_has(&cpu_data(freq->cpu), X86_FEATURE_CONSTANT_TSC))
>                return 0;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/