linux-kernel - Re: WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19f34abd0906170933m6be38a4cv2e4f49c3b78d71c4@mail.gmail.com>
Date:	Wed, 17 Jun 2009 18:33:31 +0200
From:	Vegard Nossum <vegard.nossum@...il.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write_dummy

2009/6/17 Cyrill Gorcunov <gorcunov@...il.com>:
> Vegard, could you test the patch?
>
>        -- Cyrill
> ---
>
> If we have apic disabled we don't even switch to APIC mode and do not
> calling for connect_bsp_APIC. Though on SMP compiled kernel the
> native_machine_shutdown does try to write the apic register anyway.
> Fix it with explicit check if we really should touch apic registers.
>
> Reported-by: Vegard Nossum <vegard.nossum@...il.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> ---
>  arch/x86/kernel/apic/io_apic.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.git/arch/x86/kernel/apic/io_apic.c
> =====================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/apic/io_apic.c
> +++ linux-2.6.git/arch/x86/kernel/apic/io_apic.c
> @@ -2003,7 +2003,9 @@ void disable_IO_APIC(void)
>        /*
>         * Use virtual wire A mode when interrupt remapping is enabled.
>         */
> -       disconnect_bsp_APIC(!intr_remapping_enabled && ioapic_i8259.pin != -1);
> +       if (cpu_has_apic)
> +               disconnect_bsp_APIC(!intr_remapping_enabled &&
> +                               ioapic_i8259.pin != -1);
>  }
>
>  #ifdef CONFIG_X86_32
>

Seems to work here:

[  317.596743] ACPI: Preparing to enter system sleep state S5
[  317.633421] Disabling non-boot CPUs ...
[  317.637493] Power down.
[  317.638305] acpi_power_off called

and no warning.

Thanks!


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/