linux-kernel - Re: + page_alloc-oops-when-setting-percpu_pagelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0906171331210.1695@gentwo.org>
Date:	Wed, 17 Jun 2009 13:34:26 -0400 (EDT)
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	Dimitri Sivanich <sivanich@....com>
cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, mel@....ul.ie,
	nickpiggin@...oo.com.au, linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org
Subject: Re: + page_alloc-oops-when-setting-percpu_pagelist_fraction.patch
 added to -mm tree

On Wed, 17 Jun 2009, Dimitri Sivanich wrote:

> > pcp is only protected local_irq_save(), not spin lock. it assume
> > each cpu have different own pcp. but this patch break this assumption.
> > Now, we can share boot_pageset by multiple cpus.
> >
>
> I'm not quite understanding what you mean.
>
> Prior to the cpu going down, each unpopulated zone pointed to the boot_pageset (per_cpu_pageset) for it's cpu (it's array element), so things had been set up this way already.  I could be missing something, but am not sure why restoring this would be a risk?

The boot_pageset is supposed to be per cpu and this patch preserves it.

However, all zones for a cpu have just a single boot pageset. Maybe that
was what threw off Kosaki?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/