linux-kernel - Re: [GIT PULL] block updates for 2.6.31-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1ocsmo4r8.fsf@sermon.lab.mkp.net>
Date:	Wed, 17 Jun 2009 18:49:15 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Jens Axboe <jens.axboe@...cle.com>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [GIT PULL] block updates for 2.6.31-rc1

>>>>> "Andrew" == Andrew Morton <akpm@...ux-foundation.org> writes:

Andrew> i386 allnoconfig:

Andrew> block/blk-settings.c: In function 'blk_set_default_limits':
Andrew> block/blk-settings.c:115: warning: large integer implicitly
Andrew> truncated to unsigned type

I sent Jens a fix earlier today.

Andrew> It doesn't look like it'll cause any runtime problems, but that
Andrew> just means we got lucky.

I didn't do a compile check on 32-bit, I admit that.  But the patch was
explicitly done in a way that wouldn't affect the existing I/O path.

Andrew> Or is the code just buggy?  What are the units of
Andrew> BLK_BOUNCE_HIGH, BLK_BOUNCE_ANY and BLK_BOUNCE_ISA?  Seems that
Andrew> they are physical addresses.  So why are we copying one of these
Andrew> onto a variable which records pfns?

BLK_BOUNCE_* is the DMA mask, yes.  It needs to be converted to pfns.
That's what I messed up when I ripped the call out of DM to put it in
the generic block layer function.

I'll defer to Jens wrt. the choice of -1ULL.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/