linux-kernel - Re: [GIT PULL v2] Early SLAB fixes for 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1245315134.21602.50.camel@pasglop>
Date:	Thu, 18 Jun 2009 18:52:14 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	kamezawa.hiroyu@...fujitsu.com, lizf@...fujitsu.com, mingo@...e.hu,
	yinghai@...nel.org
Subject: Re: [GIT PULL v2] Early SLAB fixes for 2.6.31

On Thu, 2009-06-18 at 09:01 +0300, Pekka Enberg wrote:
> 
> The only thing I don't like about this patch is that the caller gets
> to decide which bits should be masked. I really think this should be a
> mm_late_init() function that sets the mask _internally_ in the page
> allocator.

Well, the bits are common to slab, slub and page_allocator, so it
doesn't hurt -that- much to have init/main.c use a pre-cooked constant
from gfp.h for that :-)

Also, I still have in mind to use it to clear out some bits during
suspend resume.

But if you really want to be pedantic, we could turn that into inline
functions like gfp_boot_finished() to keep the bits local to gfp.h
completely...

> But anyway, I am about to go completely off-line until Sunday or so
> consider the approach:

Thanks for the ack.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/