linux-kernel - Re: linux-next: Tree for June 17 (pci/slot)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A399130.9050809@oracle.com>
Date:	Wed, 17 Jun 2009 17:58:24 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Alex Chiang <achiang@...com>
CC:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Matthew Wilcox <matthew@....cx>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	a.beregalov@...il.com
Subject: Re: linux-next: Tree for June 17 (pci/slot)

Alex Chiang wrote:
> * Alex Chiang <achiang@...com>:
>> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
>> index ba6af16..ed32f67 100644
>> --- a/drivers/pci/Makefile
>> +++ b/drivers/pci/Makefile
>> @@ -2,10 +2,11 @@
>>  # Makefile for the PCI bus specific drivers.
>>  #
>>  
> 
> Actually...
> 
>> -obj-y		+= access.o bus.o probe.o remove.o pci.o quirks.o slot.o \
>> +obj-y		+= access.o bus.o probe.o remove.o pci.o quirks.o \
>>  			pci-driver.o search.o pci-sysfs.o rom.o setup-res.o \
>                                               ^^^^^^^^^^^
>>  			irq.o
>>  obj-$(CONFIG_PROC_FS) += proc.o
>> +obj-$(CONFIG_SYSFS) += slot.o
> 
> Here is v2.
>   
> From: Alex Chiang <achiang@...com>
> 
> PCI: drivers/pci/slot.c should depend on CONFIG_SYSFS
> 
> There is no way to interact with a physical PCI slot without
> sysfs, so encode the dependency and prevent this build error:
> 
> 	drivers/pci/slot.c: In function 'pci_hp_create_module_link':
> 	drivers/pci/slot.c:327: error: 'module_kset' undeclared
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fix-suggested-by: Matthew Wilcox <matthew@....cx>
> Signed-off-by: Alex Chiang <achiang@...com>
> ---
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index ba6af16..0be4efd 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -2,10 +2,11 @@
>  # Makefile for the PCI bus specific drivers.
>  #
>  
> -obj-y		+= access.o bus.o probe.o remove.o pci.o quirks.o slot.o \
> -			pci-driver.o search.o pci-sysfs.o rom.o setup-res.o \
> +obj-y		+= access.o bus.o probe.o remove.o pci.o quirks.o \
> +			pci-driver.o search.o rom.o setup-res.o \
>  			irq.o
>  obj-$(CONFIG_PROC_FS) += proc.o
> +obj-$(CONFIG_SYSFS) += slot.o pci-sysfs.o
>  
>  # Build PCI Express stuff if needed
>  obj-$(CONFIG_PCIEPORTBUS) += pcie/
> --

Hi,
Yes, v2 looks better, but still has some build problems.

drivers/built-in.o: In function `pci_bus_add_device':
(.text+0x20d2): undefined reference to `pci_create_sysfs_dev_files'
drivers/built-in.o: In function `pci_stop_bus_device':
(.text+0x2e41): undefined reference to `pci_remove_sysfs_dev_files'
drivers/built-in.o: In function `proc_bus_pci_mmap':
proc.c:(.text+0x744f): undefined reference to `pci_mmap_fits'
drivers/built-in.o:(.data+0x324): undefined reference to `pci_bus_attrs'
drivers/built-in.o:(.data+0x328): undefined reference to `pci_dev_attrs'


config attached.

-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

View attachment "config-slots" of type "text/plain" (42583 bytes)