linux-kernel - [PATCH] tracing: Use DECLARE_COMPLETION_ONSTACK() for stack completion variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2009 12:01:34 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	linux-kernel@...r.kernel.org
Cc:	peterz@...radead.org, rostedt@...dmis.org,
	Matt Fleming <matt@...sole-pimps.org>
Subject: [PATCH] tracing: Use DECLARE_COMPLETION_ONSTACK() for stack completion variable

init_completion() is for use with dynamically allocated
completions. The 'isrt' completion is not dynamically allocated but is
allocated on the stack, so use the appropriate macro for lockdep's
benefit.

Signed-off-by: Matt Fleming <matt@...sole-pimps.org>
---
 kernel/trace/trace_selftest.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
index 00dd648..45e64e1 100644
--- a/kernel/trace/trace_selftest.c
+++ b/kernel/trace/trace_selftest.c
@@ -586,12 +586,10 @@ trace_selftest_startup_wakeup(struct tracer *trace, struct trace_array *tr)
 {
 	unsigned long save_max = tracing_max_latency;
 	struct task_struct *p;
-	struct completion isrt;
+	DECLARE_COMPLETION_ONSTACK(isrt);
 	unsigned long count;
 	int ret;
 
-	init_completion(&isrt);
-
 	/* create a high prio thread */
 	p = kthread_run(trace_wakeup_test_thread, &isrt, "ftrace-test");
 	if (IS_ERR(p)) {
-- 
1.6.3.2.306.g4f4fa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/