linux-kernel - Re: [BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in AES-NI accelerated ecb/cbc mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090618114032.GB6596@gondor.apana.org.au>
Date:	Thu, 18 Jun 2009 19:40:33 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Huang Ying <ying.huang@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in
	AES-NI accelerated ecb/cbc mode

On Mon, Jun 15, 2009 at 05:04:57PM +0800, Huang Ying wrote:
> Because AES-NI instructions will touch XMM state, corresponding code
> must be enclosed within kernel_fpu_begin/end, which used
> preempt_disable/enable. So sleep should be prevented between
> kernel_fpu_begin/end.
> 
> Signed-off-by: Huang Ying <ying.huang@...el.com>

I'll apply this for now.  But it would be much better to allow
sleeping in this case.

Couldn't we simply move the kernel_fpu_begin/end inside the loop?
It shouldn't be too expensive when it runs the 2nd time since it
doesn't have to save anything, right?

Cheer,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/