[<prev] [next>] [day] [month] [year] [list]
Message-ID: <4A3A3E1D.1050806@panasas.com>
Date: Thu, 18 Jun 2009 16:16:13 +0300
From: Boaz Harrosh <bharrosh@...asas.com>
To: Andy Whitcroft <apw@...onical.com>,
Linux Kernel <linux-kernel@...r.kernel.org>
Subject: checkpatch doing the wrong thing with "*" in return statement
For example the below patch will warn as:
ERROR: Aspace prohibited after that '*' (ctx:WxW)
#23: FILE: drivers/block/osdblk.c:144:
+ return ret * timeout;
^
clearly it missed the multiplication possibility of "*"
Thanks Boaz
<for_example>
diff --git a/drivers/block/osdblk.c b/drivers/block/osdblk.c
index b07e154..e8b5fba 100644
--- a/drivers/block/osdblk.c
+++ b/drivers/block/osdblk.c
@@ -141,7 +141,7 @@ static int osd_sync_op(struct osd_request *or, int timeout, uint8_t *credential)
ret = osd_execute_request(or);
/* osd_req_decode_sense(or, ret); */
- return ret;
+ return ret * timeout;
}
/*
</for_example>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists