linux-kernel - Re: [PATCH -next] bnx2i/cnic: kconfig interactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1245350361.12000.219.camel@nseg_linux_HP1.broadcom.com>
Date:	Thu, 18 Jun 2009 11:39:21 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Randy Dunlap" <randy.dunlap@...cle.com>
cc:	"Stephen Rothwell" <sfr@...b.auug.org.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Sam Ravnborg" <sam@...nborg.org>,
	"Anil Veerabhadrappa" <anilgv@...adcom.com>,
	scsi <linux-scsi@...r.kernel.org>,
	"James Bottomley" <James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH -next] bnx2i/cnic: kconfig interactions


On Thu, 2009-06-18 at 09:55 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> NETDEVICES + NETDEV_1000 need to be enabled so that kconfig will check
> those branches for selects and enforce "select UIO" under CNIC.
> Otherwise the build fails with:

I think this patch is better than your previous patch to select UIO.
Other iSCSI drivers that select net drivers will probably need something
similar too.

Thanks.
Acked-by: Michael Chan <mchan@...adcom.com>

> 
> ERROR: "uio_unregister_device" [drivers/net/cnic.ko] undefined!
> ERROR: "uio_event_notify" [drivers/net/cnic.ko] undefined!
> ERROR: "__uio_register_device" [drivers/net/cnic.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: Anil Veerabhadrappa <anilgv@...adcom.com>
> Cc: Michael Chan <mchan@...adcom.com>
> ---
>  drivers/scsi/bnx2i/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20090618.orig/drivers/scsi/bnx2i/Kconfig
> +++ linux-next-20090618/drivers/scsi/bnx2i/Kconfig
> @@ -1,6 +1,8 @@
>  config SCSI_BNX2_ISCSI
>  	tristate "Broadcom NetXtreme II iSCSI support"
>  	select SCSI_ISCSI_ATTRS
> +	select NETDEVICES
> +	select NETDEV_1000
>  	select CNIC
>  	depends on PCI
>  	---help---
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/