linux-kernel - Re: [PATCH] bootmem.c: Avoid c90 declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090618132410.0b55cd90.akpm@linux-foundation.org>
Date:	Thu, 18 Jun 2009 13:24:10 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Pekka Enberg <penberg@...helsinki.fi>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH] bootmem.c: Avoid c90 declaration warning

On Thu, 18 Jun 2009 13:07:13 -0700
Joe Perches <joe@...ches.com> wrote:

> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> diff --git a/mm/bootmem.c b/mm/bootmem.c
> index 282df0a..09d9c98 100644
> --- a/mm/bootmem.c
> +++ b/mm/bootmem.c
> @@ -536,11 +536,13 @@ static void * __init alloc_arch_preferred_bootmem(bootmem_data_t *bdata,
>  		return kzalloc(size, GFP_NOWAIT);
>  
>  #ifdef CONFIG_HAVE_ARCH_BOOTMEM
> +	{
>  	bootmem_data_t *p_bdata;
>  
>  	p_bdata = bootmem_arch_preferred_node(bdata, size, align, goal, limit);
>  	if (p_bdata)
>  		return alloc_bootmem_core(p_bdata, size, align, goal, limit);
> +	}
>  #endif
>  	return NULL;
>  }

Well yes.

We'll be needing some tabs there.

Unrelatedly, I'm struggling a bit with bootmem_arch_preferred_node(). 
It's only defined if CONFIG_X86_32=y && CONFIG_NEED_MULTIPLE_NODES=y,
but it gets called if CONFIG_HAVE_ARCH_BOOTMEM=y.

Is this correct, logical and as simple as we can make it??
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/