[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <851fc09e0906172249q40c99fc6n26662b533b063b9e@mail.gmail.com>
Date: Thu, 18 Jun 2009 13:49:33 +0800
From: huang ying <huang.ying.caritas@...il.com>
To: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
"H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>,
Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 12/16] x86, mce: squash mce_intel.c into therm_throt.c
2009/6/15 Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>:
> move intel_init_thermal() into therm_throt.c
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> ---
> arch/x86/kernel/cpu/mcheck/Makefile | 2 +-
> arch/x86/kernel/cpu/mcheck/mce_intel.c | 73 ------------------------------
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 66 +++++++++++++++++++++++++++
> 3 files changed, 67 insertions(+), 74 deletions(-)
> delete mode 100644 arch/x86/kernel/cpu/mcheck/mce_intel.c
Why we need this patch? I think the design principle behind MCE is to
separate vendor/cpu specific code into different files. At least
#ifdef CONFIG_X86_MCE_INTEL should be used around moved code.
Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists