linux-kernel - Re: backtrace symbols are bolixed...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090619173052.8460f1a9.sfr@canb.auug.org.au>
Date:	Fri, 19 Jun 2009 17:30:52 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: backtrace symbols are bolixed...

Hi Dave,

On Fri, 19 Jun 2009 00:21:01 -0700 (PDT) David Miller <davem@...emloft.net> wrote:
>
> Sometime in the last day or so backtrace symbol printouts
> have become useless:
> 
> [    0.000000] WARNING: at mm/bootmem.c:535 __stop_notes+0xbb10/0x1d660()
> [    0.000000] Modules linked in:
> [    0.000000] Call Trace:
> [    0.000000]  [00000000008611b4] __stop_notes+0xbb10/0x1d660
> [    0.000000]  [000000000086195c] __stop_notes+0xc2b8/0x1d660
> [    0.000000]  [0000000000861a28] __stop_notes+0xc384/0x1d660
> [    0.000000]  [0000000000858678] __stop_notes+0x2fd4/0x1d660
> [    0.000000]  [000000000085684c] __stop_notes+0x11a8/0x1d660
> [    0.000000]  [00000000006e8bdc] _etext+0xfffffffffffe59f4/0xe18
> [    0.000000]  [0000000000000000] (null)
> 
> I'll try to bisect but maybe someone can figure it out quickly
> meanwhile.

Try the following patch:

From: Mike Frysinger <vapier@...too.org>
Date: Mon, 15 Jun 2009 07:52:48 -0400
Subject: [PATCH] kallsyms: fix inverted valid symbol checking

The previous commit (17b1f0de) introduced a slightly broken consolidation
of the memory text range checking.

Signed-off-by: Mike Frysinger <vapier@...too.org>
---
 scripts/kallsyms.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 3cb5789..64343cc 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -167,11 +167,11 @@ static int symbol_valid_tr(struct sym_entry *s)
 	for (i = 0; i < ARRAY_SIZE(text_ranges); ++i) {
 		tr = &text_ranges[i];
 
-		if (s->addr >= tr->start && s->addr < tr->end)
-			return 0;
+		if (s->addr >= tr->start && s->addr <= tr->end)
+			return 1;
 	}
 
-	return 1;
+	return 0;
 }
 
 static int symbol_valid(struct sym_entry *s)
-- 
1.6.3.1


-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/