linux-kernel - Re: [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906190059.51576.david-b@pacbell.net>
Date:	Fri, 19 Jun 2009 00:59:51 -0700
From:	David Brownell <david-b@...bell.net>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	haavard.skinnemoen@...el.com, patrice.vilchez@...el.com
Subject: Re: [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series

On Thursday 11 June 2009, Nicolas Ferre wrote:
> Add both host and gadget USB drivers for at91sam9g45 series. Those SOC embed
> high speed USB interfaces.
> The gadget driver is the already available atmel_usba_udc.
> The host driver is an EHCI with its companion OHCI. EHCI is handled by the new
> ehci-atmel.c whereas the OHCI is always handled by ohci-at91.c. This last
> wrapper is modified to allow IRQ sharing between two controllers.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>

Talking only about the EHCI bits here ... it looks pretty generic
except for the clock management, which can't be.

The tricky bits here will be system suspend/resume support, with
the host controller able to trigger remote wakeup.  Clearly you
don't support system suspend/resume yet.

A slightly less tricky bit would be suspending the root hub.
Sometimes the hardware needs help there; other times it can
automatically gate the various clocks and save power.

If you split out patches for each of the drivers, I can ack
each of those seaprately.  And then hope to see patches which
add power management support before too long.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/