linux-kernel - Re: [PATCH] New ASoC Drivers for ADI AD1938 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245404150.21421.272.camel@vega.slimlogic.co.uk>
Date:	Fri, 19 Jun 2009 10:35:50 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Barry Song <21cnbao@...il.com>
Cc:	broonie@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] New ASoC Drivers for ADI AD1938 codec

On Fri, 2009-06-19 at 17:28 +0800, Barry Song wrote:
> 1. add AD1938 codec driver                   (codec)
> 2. add blackfin SPORT-TDM DAI and PCM driver (platform)
> 3. add bf5xx board with AD1938 driver        (machine)
> Signed-off-by: Barry Song <21cnbao@...il.com>
> ---
>  include/sound/soc-dai.h            |    1 +
>  sound/soc/blackfin/Kconfig         |   46 +++-
>  sound/soc/blackfin/Makefile        |    6 +
>  sound/soc/blackfin/bf5xx-ad1938.c  |  178 ++++++++++++
>  sound/soc/blackfin/bf5xx-tdm-pcm.c |  330 ++++++++++++++++++++++
>  sound/soc/blackfin/bf5xx-tdm-pcm.h |   21 ++
>  sound/soc/blackfin/bf5xx-tdm.c     |  295 +++++++++++++++++++
>  sound/soc/blackfin/bf5xx-tdm.h     |   14 +
>  sound/soc/codecs/Kconfig           |    4 +
>  sound/soc/codecs/Makefile          |    2 +
>  sound/soc/codecs/ad1938.c          |  548 ++++++++++++++++++++++++++++++++++++
>  sound/soc/codecs/ad1938.h          |   68 +++++
>  12 files changed, 1512 insertions(+), 1 deletions(-)
>  create mode 100644 sound/soc/blackfin/bf5xx-ad1938.c
>  create mode 100644 sound/soc/blackfin/bf5xx-tdm-pcm.c
>  create mode 100644 sound/soc/blackfin/bf5xx-tdm-pcm.h
>  create mode 100644 sound/soc/blackfin/bf5xx-tdm.c
>  create mode 100644 sound/soc/blackfin/bf5xx-tdm.h
>  create mode 100644 sound/soc/codecs/ad1938.c
>  create mode 100644 sound/soc/codecs/ad1938.h
> 

Could you break this patch into smaller chunks. This should make it
easier to review and apply.

Thanks

Liam 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/