linux-kernel - [PATCH 1/3] eventfd: Allow waiters to be notified about the eventfd file* going away

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090619185127.31118.2893.stgit@dev.haskins.net>
Date:	Fri, 19 Jun 2009 14:51:27 -0400
From:	Gregory Haskins <ghaskins@...ell.com>
To:	davidel@...ilserver.org
Cc:	mst@...hat.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	avi@...hat.com, paulmck@...ux.vnet.ibm.com, mingo@...e.hu
Subject: [PATCH 1/3] eventfd: Allow waiters to be notified about the eventfd
	file* going away

From: Davide Libenzi <davidel@...ilserver.org>

And give them a change to unregister from the wait queue.

This is turn allows eventfd users to use the eventfd file* w/out holding a
live reference to it.

After the eventfd user callbacks returns, any usage of the eventfd file*
should be dropped.  The eventfd user callback can acquire sleepy locks
since it is invoked lockless.

This is a feature, needed by KVM to avoid an awkward workaround when using
eventfd.

Signed-off-by: Davide Libenzi <davidel@...ilserver.org>
Tested-by: Gregory Haskins <ghaskins@...ell.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Gregory Haskins <ghaskins@...ell.com>
Signed-off-by: Avi Kivity <avi@...hat.com>
---

 fs/eventfd.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/fs/eventfd.c b/fs/eventfd.c
index 2a701d5..c71f51d 100644
--- a/fs/eventfd.c
+++ b/fs/eventfd.c
@@ -59,7 +59,15 @@ int eventfd_signal(struct file *file, int n)
 
 static int eventfd_release(struct inode *inode, struct file *file)
 {
-	kfree(file->private_data);
+	struct eventfd_ctx *ctx = file->private_data;
+
+	/*
+	 * No need to hold the lock here, since we are on the file cleanup
+	 * path and the ones still attached to the wait queue will be
+	 * serialized by wake_up_locked_poll().
+	 */
+	wake_up_locked_poll(&ctx->wqh, POLLHUP);
+	kfree(ctx);
 	return 0;
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/