linux-kernel - Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245455409.16880.15.camel@pasglop>
Date:	Sat, 20 Jun 2009 09:50:09 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Pavel Machek <pavel@....cz>
Cc:	Pekka J Enberg <penberg@...helsinki.fi>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu, npiggin@...e.de,
	akpm@...ux-foundation.org, cl@...ux-foundation.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or
 suspending

On Sat, 2009-06-20 at 01:23 +0200, Pavel Machek wrote:
> > No. First, code that assumes GFP_KERNEL don't fail is stupid. Any
> > allocation should always be assumed to potentially fail.
> 
> Stupid, yes. Uncommon? Not sure.

A lot less than it used to be, we've been fixing those by the truckload
over the past few years. But again, if allocations start failing that
early at boot, you are likely to be doomed anyway. Still, better to do
proper error handling, and I think we -mostly- do (ok, not -always-).

> > Then, if you start failing allocations at boot time, then you aren't
> > going anywhere are you ?
> 
> Exactly. So boot code should have access to all the memory, right?
> Setting some aside for GFP_ATOMIC does not make sense in that context.

I'm not certain what you mean here. If you're going to hit the atomic
reserve that early, you aren't going anywhere neither :-)

Is there any real problem you are trying to solve here or is it all
just academic ?

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/