[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4A3B1C38.5080607@cn.fujitsu.com>
Date: Fri, 19 Jun 2009 13:03:52 +0800
From: Li Zefan <lizf@...fujitsu.com>
To: Tom Zanussi <tzanussi@...il.com>
CC: Frederic Weisbecker <fweisbec@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...e.hu>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tracing/filters: remove error messages
Tom Zanussi wrote:
> On Thu, 2009-06-18 at 09:17 +0800, Li Zefan wrote:
>> Frederic Weisbecker wrote:
>>> On Wed, Jun 17, 2009 at 04:47:15PM +0800, Li Zefan wrote:
>>>> Now we restore original filter is the new one can't be applied,
>>>> and no long show error messages, so we can remove them totally.
>>> Why?
>>> These messages are very powerful to point a user to its mistakes
>>> in filters syntaxes or semantics.
>>>
>>> I really think we are removing a very useful feature in this patch.
>>>
>> I think it's better done by providing a user-space program/script.
>>
>> So what's the criterion to decide what should be in kernel and
>> what should be in user-space?
>>
>
> I thought there wasn't supposed to be any userspace for non-binary
> tracing.
This is a good point, and I agree on this direction.
> If there is, then yeah, you can get rid of the error messages
> in the kernel because your userspace program can arrange to never submit
> an erroneous filter.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists