linux-kernel - Re: [POWERNOW PATCH] x86: powernow-k8 move power management MSRs declaration to msr-index.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090620144539.GA19293@redhat.com>
Date:	Sat, 20 Jun 2009 10:45:39 -0400
From:	Dave Jones <davej@...hat.com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [POWERNOW PATCH] x86: powernow-k8 move power management MSRs
	declaration to msr-index.h

On Sat, Jun 20, 2009 at 03:56:21PM +0530, Jaswinder Singh Rajput wrote:
 > 
 > Keep all MSRs declaration in msr-index.h to easily access MSRs declaration.
 > 
 > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>

The objection I have to this, is that there's no other use for these MSRs
outside of a powernow driver. They aren't "power management MSRs"
they're "powernow MSRs".

IMO msr-index should be used for MSRs that may be used by multiple files,
reducing duplication.  Here we're just moving something around for
no obvious benefit.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/