linux-kernel - Re: [PATCH -tip] x86: mm/init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090621113505.GA25243@elte.hu>
Date:	Sun, 21 Jun 2009 13:35:05 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: mm/init_32.c fix style problems


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> 
> Impact: cleanup
> 
> Fix :
> 
> WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> ERROR: do not initialise externals to 0 or NULL
> ERROR: code indent should use tabs where possible
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: spaces required around that ':' (ctx:ExV) X 3
> 
> total: 6 errors, 1 warning
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  arch/x86/mm/init_32.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)

Just like with hugetlbpage.c, this file too has other problems 
beyond trivial style issues:

 - one_page_table_init() logic should be restructured to have its 
   branch condition inverted into a goto out pattern, to get rid of 
   the ugly linebreaks.

 - that ugly check in page_table_kmap_check() should be factored out
   into a helper inline

 - kernel_physical_mapping_init() is too large and should have its 
   innards factored out into one or more helper inlines.

 - there's too many #idefs obscuring the easy readability of the 
   code. Could some be eliminated?

Some style issues as well:

 - printk(KERN_* should be converted to pr_*(

 - the #include files section looks unstructured and ugly. Please 
   take a look at arch/x86/mm/fault.c and try to eliminate all 
   unnecessary include lines and follow the format of fault.c.

These (and other issues) should be addressed as well, so that we 
have a single act of churn there, followed by a quality end result.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/