linux-kernel - Re: BUG: scheduling while atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090622100453.2a1bde3b@lxorguk.ukuu.org.uk>
Date:	Mon, 22 Jun 2009 10:04:53 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sergey Senozhatsky <sergey.senozhatsky@...l.by>
Cc:	Rabin Vincent <rabin@....in>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: BUG: scheduling while atomic

On Sat, 20 Jun 2009 21:54:52 +0300
Sergey Senozhatsky <sergey.senozhatsky@...l.by> wrote:

> On (06/20/09 23:13), Rabin Vincent wrote:
> > On Fri, Jun 19, 2009 at 09:15:29PM +0300, Sergey Senozhatsky wrote:
> > > Hello.
> > > I see lots of "BUG: scheduling while atomic" with current kernels (started with 2.6.30-git1, 2.6.30 is ok).
> > > For example (2.6.30-git14):
> > 
> > Looks like the net softirq (via ppp) ends up calling tty_throttle(), and
> > this causes problems because of the mutex_lock() added there by
> > 38db8979.  I've cc'd the tty maintainer.

Looks like we caught another naughty. It's not safe to call the
throttle/unthrottle methods from an IRQ path, never really has been as
they can be things like USB drivers that need to send USB messages and
sleep when that happens.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/