linux-kernel - Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A3F9515.3080200@redhat.com>
Date:	Mon, 22 Jun 2009 17:28:37 +0300
From:	Avi Kivity <avi@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	Gregory Haskins <gregory.haskins@...il.com>,
	Gregory Haskins <ghaskins@...ell.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, mtosatti@...hat.com,
	paulmck@...ux.vnet.ibm.com, markmc@...hat.com
Subject: Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support

On 06/22/2009 04:13 PM, Michael S. Tsirkin wrote:
>> Right, understood.  What I meant specifically is that if the (void*)val
>> pointer is allowed to be misaligned we are in trouble ;).  I haven't
>> studied the implementation in front of the MMIO callback recently, but I
>> generally doubt thats the case.  More than likely this is some buffer
>> that was kmalloced and that should already be aligned to the machine word.
>>
>> Kind Regards,
>> -Greg
>>
>>      
>
> Yes, from what I saw of the code I think it can be BUG_ON.
> Avi?
>    

Yes, BUG_ON is safe here.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/